acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

Add Support for hosttech.ch/hosttech.eu

Open baerengraben opened this issue 10 months ago • 4 comments

Adding Support for hosttech.ch/hosttech.eu

New try to pass workflow.

baerengraben avatar Jan 23 '25 20:01 baerengraben

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2 We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

github-actions[bot] avatar Jan 23 '25 20:01 github-actions[bot]

I have updated the outdated https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test. It now describes how to add security variables to github in 2025.

Now Docker test fails. This is despite the DNS entries being correctly added to hosttech (https://github.com/baerengraben/acme.sh/actions/runs/12955768870/job/36247925398#step:5:3911) and removed again successfully (https://github.com/baerengraben/acme.sh/actions/runs/12955768870/job/36247925398#step:5:7071).

I suspect there is something wrong with the workflow here. Can a maintainer check this?

baerengraben avatar Jan 27 '25 21:01 baerengraben

no, the test is good. you need to check your code.

Neilpang avatar Feb 08 '25 18:02 Neilpang

@Neilpang I fear it is not an issue with my code. I'm using my script already for months on an Opnsense Firewall with no issues at all. I rather suspect a problem in (my?) handling of Git-Hub actions.

This Workflow (Docker step, that fails) successfully creates the acme-challenge as TXT records on the Hosttech DNS server and also deletes them successfully. I can monitor this live on the DNS server. Nevertheless, the workflow fails. It is possible that I am not applying the workflow correctly in some way. I also can't make sense of the workflow error message. From my perspective, the script (my code) works correctly, but somehow the workflow returns "Fail."

On https://github.com/baerengraben/acme.sh/actions/runs/13220004347/job/36904036748#step:5:99

Testing wildcard domain. 
TestingDomain='***'
/root/.acme.sh/acme.sh --server "letsencrypt_test"  --issue -d "***" -d "*.***" --dns *** --dnssleep "***"  [PASS]
/root/.acme.sh/acme.sh --deactivate -d "***" >/dev/null 2>&1 [PASS]
/root/.acme.sh/acme.sh --revoke -d *** [PASS]
[Sat Feb  8 23:14:50 UTC 2025] The domain '***' seems to already have an ECC cert, let's use it.
 [FAIL] 
Run Failed

Unfortunately, I don't fully understand in detail what the workflow is testing. It seems to be testing a wildcard domain, but I don't have a wildcard domain under the TESTINGDOMAIN variable at all.

Can you please help me figure out how to get this workflow to work?

baerengraben avatar Feb 08 '25 23:02 baerengraben