acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

fix regex of matching hetzner dns api error responses

Open linsein opened this issue 11 months ago • 6 comments

'"error":{[^}]*}' is a invalid regexp for busybox egrep:

$ docker run -it --rm busybox:1.36 ash
/ # echo '"error":{"details": "message"}' | /bin/busybox egrep '"error":{[^}]*}'
egrep: bad regex '"error":{[^}]*}': Invalid content of \{\}
/ # echo '"error":{"details": "message"}' | /bin/busybox egrep '"error":\{[^\}]*\}'
"error":{"details": "message"}

There is a similar and correct regexp at https://github.com/acmesh-official/acme.sh/blob/f981c782bb38015f4778913e9c3db26b57dde4e8/acme.sh#L5074

linsein avatar Jan 13 '25 02:01 linsein

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2 We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

github-actions[bot] avatar Jan 13 '25 02:01 github-actions[bot]

This is a pretty small PR.
Should this also run DNS-API-TEST ?

linsein avatar Jan 13 '25 02:01 linsein

OK, there are other issues on OpenBSD: https://github.com/lindsayzhou/acme.sh/actions/runs/12739946412/job/35506131990#step:4:1880

I'll fix it in my spare time.

linsein avatar Jan 13 '25 04:01 linsein

OK, there are other issues on OpenBSD: https://github.com/lindsayzhou/acme.sh/actions/runs/12739946412/job/35506131990#step:4:1880

Seems caused by test scripts https://github.com/acmesh-official/acmetest/blob/8bb3e1a8c5fb3d672eabb6f0781eba8e89e1dbd8/letest.sh#L1504

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2 We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

DNS-API-TEST passed Docker, MacOS, Windows and FreeBSD.

linsein avatar Jan 13 '25 08:01 linsein

its's not passing yet.

https://github.com/lindsayzhou/acme.sh/actions/runs/12739946412

Neilpang avatar Feb 19 '25 20:02 Neilpang

its's not passing yet.

@Neilpang As I mentioned before, it's seem caused by test scripts if run the le_test_dnsapi test.

Action failed with logs:

  head: unknown option -- c
  usage: head [-count | -n count] [file ...]

The head command in OpenBSD does not support the -c flag, see https://man.openbsd.org/OpenBSD-7.6/head.1

linsein avatar Feb 21 '25 07:02 linsein