acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

Power-MIAB create

Open lifeboy opened this issue 1 year ago • 2 comments

Power-Mail-in-a-Box has an upgraded API interface which requires a slightly modified call mechanism to create TXT records. This was previously added to dns_miab.sh, but the conflict has necessitated this separate api_pmiab.sh.

lifeboy avatar Oct 14 '24 19:10 lifeboy

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

github-actions[bot] avatar Oct 14 '24 19:10 github-actions[bot]

First attempt pull-request was wrong, hence this new one.

lifeboy avatar Oct 14 '24 19:10 lifeboy

Bump

lifeboy avatar Oct 22 '24 12:10 lifeboy

https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

Neilpang avatar Nov 03 '24 12:11 Neilpang

https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

Below it shows all checks have passed? Sorry if I'm ignorant of the process, but what did I miss, @Neilpang ?

lifeboy avatar Nov 03 '24 14:11 lifeboy

https://github.com/lifeboy/acme.sh/actions/runs/11363252926

Neilpang avatar Nov 03 '24 17:11 Neilpang

All checks are now completed successfully.

lifeboy avatar Nov 04 '24 09:11 lifeboy

@Neilpang, is there something I still have to do before this can be merged?

lifeboy avatar Nov 13 '24 09:11 lifeboy

https://github.com/lifeboy/acme.sh/actions/runs/11813151134

Neilpang avatar Nov 13 '24 19:11 Neilpang

https://github.com/lifeboy/acme.sh/actions/runs/11813151134

I need some actual pointers on how to address this issue. The log that github generates doesn't show the detail of why a script fails. It's doesn't show the values it uses for the tests, it only shows '******' and I have searched for a long time how to work out what goes wrong. I rerun the same thing a couple of times, recreate the secrets and then suddenly it runs fine. No reasons giving and I'm none the wiser. Surely this is not the way to do software testing?? Shooting shots into the dark without knowing what's going on??

lifeboy avatar Nov 17 '24 18:11 lifeboy