acmesh-official
Fix MIAB dns create TXT record format
Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Ok, the change has been tested and is working. Anything else that I need to do to get the change merged?
On Mon, 26 Aug 2024 at 11:14, github-actions[bot] @.***> wrote:
Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide http://../wiki/DNS-API-Dev-Guide and DNS-API-Test http://../wiki/DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test http://../wiki/DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.
— Reply to this email directly, view it on GitHub https://github.com/acmesh-official/acme.sh/pull/5268#issuecomment-2309737758, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEZPJYKUB354MRGJWG2DX3ZTLWXNAVCNFSM6AAAAABNDTKDL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZG4ZTONZVHA . You are receiving this because you authored the thread.Message ID: @.***>
I'm struggling with the test. Do I need to run tests for all the possible environments, or do I test it on Linux 64bit (for example) and then redo a PR? The dns.yml file contains all the possible environments...
The change now has passed all the tests which would run... I presume the skipped tests are intentional?