Fixes issue 4956: 'Linode DNS Pagination Bug'
fixes issue #4956
previous code only worked for the first 10 domains on the account (as Linode API returned a paginated response, with only 10 records).
This change makes an exact search query for each subdomain, completely removing any need for walking through paginated responses. What makes it work for large accounts with any number of domains.
Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.
Can this be merged into dev, please?
https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test
Hi @Neilpang,
I tried testing it accordingly to what is written in the DNS-API-Test, but there's a job that fails. I also couldn't ask for help because the repository was closed for new commenters last week.
Currently there's a job failing:
Run echo "Read this: https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test"
echo "Read this: https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test"
if [ "vmmello" != "acmesh-official" ]; then
false
fi
shell: /usr/bin/bash -e {0}
Read this: https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test
Error: Process completed with exit code 1.
I've read the instructions several times, but it's not clear what I'm doing wrong. From the msg above it looks like it's not expecting the tests to run on my account, though for what I understand, the instructions on DNS-API-Test tell that secrets should be set on my account.
Can you please help?
I think the instructions are clear enough. I wish I could help.
You must define TokenName1 /TokenValue1
Hi @Neilpang. I figured it out. Thanks for the reply anyway.
This is done. It's ready for testing and merging.