acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

Add custom comment option

Open mib1185 opened this issue 1 year ago • 5 comments

This adds an option, where the user can add some custom comments to each certificate configuration. This would be helpful to add additional information to a certificate like it's usage or any other comments.

example: real domain is redacted

# acme.sh --issue -d mib1185-test.mydomain.com --comment "this is just a test comment" -w /var/www
[...]

# acme.sh --info -d mib1185-test.mydomain.com
[Thu Mar 14 15:47:24 CET 2024] The domain 'mib1185-test.mydomain.com' seems to have a ECC cert already, lets use ecc cert.
DOMAIN_CONF=/ACME/configfiles/mib1185-test.mydomain.com_ecc/mib1185-test.mydomain.com.conf
Le_Domain=mib1185-test.mydomain.com
Le_Alt=no
Le_Webroot=/var/www
Le_PreHook=
Le_PostHook=
Le_RenewHook=
Le_Comment=this is just a test comment
Le_API=https://acme-v02.api.letsencrypt.org/directory
[...]

mib1185 avatar Mar 14 '24 14:03 mib1185

@Neilpang unfortunately i'm not allowed to restart the failed CI job, but it seems not to be related to the change itself.

mib1185 avatar Mar 18 '24 12:03 mib1185

@Neilpang do you mind to restart the CI?

mib1185 avatar Apr 08 '24 10:04 mib1185

Hi @Neilpang i don't understand the failing test and if it is related to my change. do you have any hints on this and how to resolve it?

mib1185 avatar Apr 30 '24 12:04 mib1185

sorry, but I don't think this is a good idea to support comments after thinking more about it. It's not necessary.

Neilpang avatar Apr 30 '24 12:04 Neilpang

i agree that it is technically not necessary, but would help a lot to handle and manage multiple certificates per any kind of automation tools (eq. ansible)

mib1185 avatar Apr 30 '24 13:04 mib1185