acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

synology dsm deploy hook environment variable letter case mistake in wiki (wiki中环境变量大小写错误)

Open cokebar opened this issue 11 months ago • 2 comments

In acme.sh/deploy/synology_dsm.sh, some variable use full UPPER case letters, but some only capitalize the first letter:

# Get username & password, but don't save until we authenticated successfully
  _getdeployconf SYNO_USE_TEMP_ADMIN
  _getdeployconf SYNO_Username
  _getdeployconf SYNO_Password
  _getdeployconf SYNO_Create
  _getdeployconf SYNO_DID
  _getdeployconf SYNO_TOTP_SECRET
  _getdeployconf SYNO_Device_Name
  _getdeployconf SYNO_Device_ID

But in wiki page, wrong case has been used: image

If following the wiki, the variable won't be read by the script. You'll probably get a error like:

Unable to find certificate:  & $SYNO_Create is not set
Error deploy for domain: xxx

cokebar avatar Mar 02 '24 05:03 cokebar

Please upgrade to the latest code and try again first. Maybe it's already fixed. acme.sh --upgrade If it's still not working, please provide the log with --debug 2, otherwise, nobody can help you.

github-actions[bot] avatar Mar 02 '24 05:03 github-actions[bot]

Notice: This section has been pre-updated, before PR#5023 got merged, you shall read the old doc.

scruel avatar Mar 04 '24 07:03 scruel