acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard
verified publisher icon acmesh-official

Added functionality for Palo Alto Firewall deployments (PANOS)

Open sg1888 opened this issue 2 years ago • 4 comments

This resolves acmesh-official/acme.sh#4309 (wildcard certs) as well as issues deploying ecc certificates to Palo Alto firewalls. Wildcard certificates will now have their asterisk * replaced with WILDCARD_ on the firewall.

Ex: The certificate *.mydomain.com will be saved as WILDCARD_.mydomain.com on PanOS.

sg1888 avatar Mar 31 '23 00:03 sg1888

@Neilpang - can you pls merge this into the dev branch?

sg1888 avatar Apr 19 '23 20:04 sg1888

fix the ci errors first

Neilpang avatar Apr 20 '23 10:04 Neilpang

fix the ci errors first

@Neilpang - Made the changes.

sg1888 avatar Apr 24 '23 19:04 sg1888

@Neilpang - Can you please run the checks on the latest code? I believe the latest code should pass the CI checks.

Thank you.

sg1888 avatar May 30 '23 14:05 sg1888

@Neilpang - Hi Neil - any updates on the pull request? There have been a few people looking for wildcard cert functionality on PanOS. Right now wildcard cert deployments fail with PANOS without any clear explanation as to the reason (it's the '*' in the filename). Let me know if there are any additional questions you have on the code.

Thanks!

sg1888 avatar Jun 14 '23 16:06 sg1888

@Neilpang - Checking in to see if you've had a chance to review the PR. Any thoughts / comments?

sg1888 avatar Jul 07 '23 22:07 sg1888

The latest update also resolves acmesh-official/acme.sh#4197 and incorporates changes made by @Hossy at https://github.com/acmesh-official/acme.sh/pull/4198

sg1888 avatar Jul 12 '23 00:07 sg1888

@Neilpang - Can you please merge these to the dev branch?

sg1888 avatar Jul 19 '23 02:07 sg1888