acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

Published 20 hours ago • verified publisher icon acmesh-official

Patch 1

Open Edmund-Blackadder opened this issue 3 years ago • 5 comments

The ID was not getting extracted from the record data. The " character before the numbers was missing.

This made it so that the TXT records were not getting removed from Njalla.

Working regex https://regex101.com/r/fy1lIO/1

Edmund-Blackadder avatar Oct 15 '22 06:10 Edmund-Blackadder

Welcome Please make sure you're read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨

github-actions[bot] avatar Oct 15 '22 06:10 github-actions[bot]

I'm not quite sure how this all works, first contribution on Github so far.

Edmund-Blackadder avatar Oct 15 '22 06:10 Edmund-Blackadder

https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Dev-Guide https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

Neilpang avatar Oct 16 '22 08:10 Neilpang

I am at a loss here.

I read the documentation and have now configured the secrets for the workflow. However, I do not know how to start it again.

The documentation from both links also states these checks are needed when you are adding a new API. I have only found an issue in an already existing one. Do I still need to do something now?

I am not a programmer and have barely used github, can you please help me out here?

Edmund-Blackadder avatar Oct 16 '22 10:10 Edmund-Blackadder

However, I do not know how to start it again.

Please just push any changes to your repo again, the actions will run there.

Neilpang avatar Oct 16 '22 10:10 Neilpang