acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

Fix dnsmadeeasy on non english systems

Open Nickinthebox opened this issue 3 years ago • 4 comments

DNS Made Easy API checks for an English date header otherwise it create an error.

In deed, we have in logs: response='{"error": ["Invalid request date header: dim., 28 août 2022 09:24:45 UTC"]}' (my system was in French)

Using local locale makes it work fine.

Nickinthebox avatar Aug 28 '22 09:08 Nickinthebox

Welcome Please make sure you're read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨

github-actions[bot] avatar Aug 28 '22 09:08 github-actions[bot]

Fixes this issue: https://github.com/acmesh-official/acme.sh/issues/4272

Nickinthebox avatar Aug 28 '22 09:08 Nickinthebox

would you mind fixing the CI errors. And pass the dns api test: https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

Neilpang avatar Sep 06 '22 12:09 Neilpang

https://github.com/Nickinthebox/acme.sh/actions/runs/3000795584

Neilpang avatar Sep 23 '22 14:09 Neilpang