acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

Vultr DNS: fix "grep: repetition-operator operand invalid" on FreeBSD

Open skyksandr opened this issue 3 years ago • 2 comments

@mjkrg reports here https://github.com/acmesh-official/acme.sh/issues/2374 integration is no longer working on FreeBSD. This PR aims to fix it.

On line 119, containing the command grep '^\{.*\}', on FreeBSD it needs an -E option to be able to parse the extended regular expression otherwise it chokes with the error message: "grep: repetition-operator operand invalid".

skyksandr avatar Aug 24 '22 01:08 skyksandr

Welcome Please make sure you're read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨

github-actions[bot] avatar Aug 24 '22 01:08 github-actions[bot]

https://github.com/skyksandr/acme.sh/actions/runs/2916012688

Neilpang avatar Sep 18 '22 13:09 Neilpang

@Neilpang Here is CI run after rebasing on current master: https://github.com/skyksandr/acme.sh/actions/runs/4081483447

skyksandr avatar Feb 03 '23 07:02 skyksandr