acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

Published 20 hours ago • verified publisher icon acmesh-official

Fix missing HTTP_HEADER for _get with wget

Open agowa opened this issue 2 years ago • 9 comments

Save http header to file for _get with wget.

Fixes: #4251

agowa avatar Aug 17 '22 14:08 agowa

After this PR there is still one issue that I'm currently investigating. This PR mostly fixes the issue. BUT for some reason the log level needs to be at least set to --debug 2 --force --notify-level 0 With --debug 1 --force --notify-level 0 it still fails.

with the lower log level somehow two spaces are written into the header file prefixing all lines. This breaks the grep filters "^HTTP" in the dns modules".

agowa avatar Aug 17 '22 16:08 agowa

With higher debug level a debug flag is passed to wget, resulting in the headers being written twice into the file. Once the regular way prefixed with two spaces and once without. image

this is why the regex ^HTTP matches only with increased debug output.

agowa avatar Aug 17 '22 17:08 agowa

The debug issue is now also solved.

Ready for review

agowa avatar Aug 17 '22 18:08 agowa

don't wrorry about the failed tests for " invalid public key in CSR: public key is forbidden". It's because the letsecnrypt CA changed policy yesterday. I will fix the test code soon.

Neilpang avatar Aug 18 '22 01:08 Neilpang

please rebase and run the tests again.

Neilpang avatar Aug 20 '22 06:08 Neilpang

I rebased. @Neilpang As a first time contributor someone else needs to approve running the tests again. image

agowa avatar Aug 24 '22 17:08 agowa

fix the ci errors

Neilpang avatar Sep 18 '22 13:09 Neilpang

~I fixed the linting issue. But I think there was another one. Sadly GitHub doesn't show me the CI run anymore since I pushed the first fix to my branch. :/~ Nevermind, I found it. Even though the CI doesn't show up here. It shows up when I go over to my forked repository and it's currently running...

agowa avatar Sep 18 '22 20:09 agowa

CI is fixed.

agowa avatar Sep 18 '22 21:09 agowa

https://github.com/acmesh-official/acme.sh/blob/master/acme.sh#L461

Neilpang avatar Sep 24 '22 13:09 Neilpang

And where's the -q there???

agowa avatar Sep 25 '22 01:09 agowa

I'm still unsure if omitting the -q parameter may introduce unexpected behavior, but after testing it looks fine at least with normal expected input...

Do you have more information on how this part of the documentation of grep is meant to be understood and if it is relevant?

Exit immediately with zero status if any match is found, even if an error was detected

agowa avatar Sep 27 '22 20:09 agowa