acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

Published 20 hours ago • verified publisher icon acmesh-official

Update dns_cpanel.sh

Open sm622 opened this issue 2 years ago • 3 comments

@Neilpang @arnebjarne Please check the changes as suggested. It is working fine for me. But I am not a pro for git or Solaris.

sm622 avatar Jul 12 '22 00:07 sm622

don't send to master branch. please send to dev branch instead.

you don't have to be a pro.

Neilpang avatar Jul 12 '22 01:07 Neilpang

don't send to master branch. please send to dev branch instead.

you don't have to be a pro.

changed to dev

sm622 avatar Jul 12 '22 01:07 sm622

run the CI checks in your fork: https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

Neilpang avatar Jul 12 '22 08:07 Neilpang

@sm622 What does this commit solve? I cannot read that from the commit comment. I cannot approve anything i do not understand :)

arnebjarne avatar Oct 01 '22 15:10 arnebjarne

@sm622 What does this commit solve? I cannot read that from the commit comment. I cannot approve anything i do not understand :)

These changes are already done. Actually Cpanel DNS updates were not working previously. You already solved the issue in below commit.

https://github.com/acmesh-official/acme.sh/commit/c485011ed1d714540163013f14418dce937dbac1

sm622 avatar Oct 02 '22 08:10 sm622

@sm622 or @Neilpang . Can one of you please close, decline or delete this Pull Request then (I do not have such rights to this PR) ?

arnebjarne avatar Oct 02 '22 09:10 arnebjarne