acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

Make `AWS_HOST` and `Region` configurable, which fixes issue #2722.

Open lyenliang opened this issue 2 years ago • 5 comments

I make AWS_HOST and Region configurable with environment variables.

You can now use acme.sh with AWS China using the following command. AWS_HOST=api.route53.cn Region=cn-northwest-1 ./acme.sh --issue ...

lyenliang avatar May 12 '22 06:05 lyenliang

请问这项修改有没有需要调整的部份?

lyenliang avatar May 20 '22 06:05 lyenliang

AWS_HOST 和 Region 需要 成为像 AWS_ACCESS_KEY_ID 一样的变量. 一样的读取, 一样的保存. 像你这种改法, 是没办法自动 renew 的. 因为 renew 时, 没人去定义AWS_HOST 变量, 又会使用默认值了.

Neilpang avatar May 20 '22 09:05 Neilpang

了解,我目前對 AWS_HOSTRegion 初步想到的逻辑是这样子:

if AWS_HOST environment variable is defined:
    if AWS_HOST does not exist in config:
        write AWS_HOST to config
    set AWS_HOST as ${AWS_HOST}
else:
    if AWS_HOST exists in config:
        set AWS_HOST as config's AWS_HOST value
    else:
        write "route53.amazon.com" to config
        set AWS_HOST as "route53.amazon.com"

有空我再来实现。

感谢你的提示。

lyenliang avatar May 27 '22 09:05 lyenliang

没这么复杂. 照着 AWS_ACCESS_KEY_ID 写就可以了.

Neilpang avatar May 27 '22 09:05 Neilpang

咦~ 可是 AWS_HOSTRegion 都有预设值(分别是 route53.amazonaws.comus-east-1),这个特性跟 AWS_ACCESS_KEY_ID 不同,为什么说可以照 AWS_ACCESS_KEY_ID 的逻辑写就好呢?

lyenliang avatar May 28 '22 09:05 lyenliang