Fixes #3645, sed errors in dns_linode_v4.sh

[ddribin]

Use "{" instead of "{".

[ddribin]

I spend at least an hour trying to get the Actions to pass, but TokenName1 = TokenValue1 was never getting set as an environment variable, and I could not set an Linode API key from a secret.

[Neilpang]

please set up and make the CI pass.

[ddribin]

As I mentioned above, I could not get it to work, following this link:

https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

I get this error:

[Sat Aug  7 05:33:43 UTC 2021] You didn't specify the Linode v4 API key yet.

Even though I did set:

TokenName1 = LINODE_V4_API_KEY
TokenValue1 = <my-api-key>

@Neilpang, can you help me figure out why? I have not used GitHub Actions very much.

[Neilpang]

no, I don't know why. it should be easy.

[ddribin]

I think a recent change in acmetest is causing Linode in Docker not to work. See https://github.com/acmesh-official/acmetest/commit/8af6bcf45b81602818a21e1725520c4712c70dc0#r54561469

[Neilpang]

Sorry, it's fixed now.

please rebase and try again.

Thanks.

[ddribin]

The straight dev branch failed two tests, DNS and Linux:

But my commit failed three, DNS, Linux, and Ubunutu:

Looking at the logs it says:

Ubuntu (ZeroSSL.com, ZeroSSL ECC Domain Secure Site CA, ZeroSSL RSA Domain Secure Site CA, github...
The job was canceled because "LetsEncrypt_org_test" failed.

@Neilpang: Seems unrelated to my change, no?

[Neilpang]

re-run it.

[ddribin]

Failed again:

/home/runner/.acme.sh/acme.sh --revoke -d obtaining-guitars-pick-beautiful.trycloudflare.com [PASS]
124
------------------------------------------
125
Progress: 10/0/19
126
==Running le_test_standandalone_listen_v6_v2 please wait
127
Skipped by TEST_IPV6
128
------------------------------------------
129
Progress: 11/0/19
130
==Running le_test_standandalone_deactivate_v2 please wait
131
 [FAIL] 
132
Run Failed
133
/home/runner/.acme.sh/acme.sh  --server "ZeroSSL.com"  --issue -d obtaining-guitars-pick-beautiful.trycloudflare.com --standalone --certpath '/home/runner/work/acme.sh/acmetest/certs/domain.cer' --keypath '/home/runner/work/acme.sh/acmetest/certs/domain.key'  --capath '/home/runner/work/acme.sh/acmetest/certs/ca.cer'  --reloadcmd 'echo this is reload'  --fullchainpath  '/home/runner/work/acme.sh/acmetest/certs/full.cer'------------------------------------------
134
==Running le_test_standandalone_deactivate_v2 please wait
135

Should I upload the whole log file?

[ddribin]

Attached a log archive of the Ubuntu. I'm afraid I don't know what's going on, so you'll have to accept/deny this PR as-is, unless you can figure out the CI issues. All I know is this solves the problem for me. Solaris did pass in CI, which is good since Solaris is the only reason the _egrep_o() exists.

logs_32.zip

[Neilpang]

Just click the "Rerun" button on the CI jobs to run your tests again, it sometimes fails.

[ddribin]

Looks like Ubuntu finally passed. @Neilpang: Is there anything else you're looking for, in order to merge?

[Neilpang]

please rebase and check the tests again.

[ddribin]

It's already rebased on current dev ?

* b17acf1 - (HEAD -> sed-error-3645) Fixes #3645, sed errors in dns_linode_v4.sh (4 weeks ago) <Dave Dribin>
* 72e3f33 - (dev) fix docker test (4 weeks ago) <neilpang>

[ddribin]

I just checked and there's nothing new on the dev branch. @Neilpang: What is holding this PR back from getting merged?

[Neilpang]

https://github.com/ddribin/acme.sh/actions/runs/1109369260

[ddribin]

My Linode key had expired, and I needed to rebase to dev. I've updated everything, and it It all works locally. Yet the the DNS API Test action still fails https://github.com/ddribin/acme.sh/actions/runs/1408717835

I cannot figure out why it's failing. I've spent many hours trying to get this DNS API Test action passing for a straightforward two line change. Unfortunately, I cannot spend any more time in this PR. Hopefully you can take it from here.