acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

Implement service account key authentication dns_gcloud.sh

Open acazacu opened this issue 3 years ago • 6 comments

A comprehensive description of what this pull request changes can be read here: https://github.com/acmesh-official/acme.sh/issues/3531.

Once merged, the wiki should be updated to reflect the added functionality.

acazacu avatar Jun 01 '21 20:06 acazacu

Can we please merge this PR into the master?

jmcombs avatar Oct 27 '22 15:10 jmcombs

Is this change compatible with the existing acme.sh users? I mean the existing certs can renew without any changes?

Neilpang avatar Oct 29 '22 01:10 Neilpang

Is this change compatible with the existing acme.sh users? I mean the existing certs can renew without any changes?

So, I actually have the existing dnsapi_gcloud implementation working with service account credentials. I figured this out after I posted my comment above so, to me, this PR is moot. I am happy to update the documentation on the Wiki for how to use a service account however, I don't think Wiki pages on Github allow me to submit a PR to do so. So, let me know how you'd like the updated instructions for https://github.com/acmesh-official/acme.sh/wiki/dnsapi#49-use-google-cloud-dns-api-to-automatically-issue-cert and I can provide them.

jmcombs avatar Oct 29 '22 11:10 jmcombs

@jmcombs would you mind putting some documentation in this issue until they update the wiki? Would be very helpful :-)

typytypytypy avatar Oct 31 '22 14:10 typytypytypy

@acazacu were you able to find a workaround to get dns_gcloud working with pfsense?

typytypytypy avatar Oct 31 '22 15:10 typytypytypy

@typytypytypy I wanted to keep running acme.sh in Docker so I created and published a container that runs the Google Cloud SDK and acme.sh. It and the instructions on how to use it with service accounts are on Docker jmcombs/acme.sh-gcloud. GitHub repo is https://github.com/jmcombs/acme.sh-gcloud. Those instructions can be used for doing this with local installs of acme.sh and gcloud SDK. I hope that helps.

jmcombs avatar Oct 31 '22 18:10 jmcombs

@acazacu were you able to find a workaround to get dns_gcloud working with pfsense?

Yes, after spending one year looking at this stale PR, I found Cloudflare!

acazacu avatar Mar 27 '23 16:03 acazacu