acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

Published 20 hours ago • verified publisher icon acmesh-official

add freemyip.com dnsapi

Open recolic opened this issue 4 years ago • 18 comments

recolic avatar Apr 27 '21 10:04 recolic

Could someone help to approve the running workflows? Thanks

recolic avatar Apr 27 '21 10:04 recolic

I fixed the shfmt issue just now. Could you approve the workflow and review again?

recolic avatar Apr 27 '21 13:04 recolic

read this link first: https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Dev-Guide

Neilpang avatar May 01 '21 02:05 Neilpang

https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

Neilpang avatar May 01 '21 02:05 Neilpang

Hi, I have resolved all comments. Maybe it's ready for merge.

Sorry for the inconvenience. I have already read the DNS-API-Dev-Guide before opening this PR, but it didn't mention the rule about "including sample token" and "token variable name should be uppercase".

recolic avatar May 02 '21 16:05 recolic

Hi, how may I help with this PR? I want this to be merged as well.

Cediddi avatar Apr 12 '22 15:04 Cediddi

Is there any further effort required to get it merged? Thanks

recolic avatar Apr 12 '22 15:04 recolic

https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

Neilpang avatar Apr 13 '22 02:04 Neilpang

https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

The pipeline is not succeeding even if I have reverted all my code change: https://github.com/recolic/acme.sh/commits/master

image

I'm confused to that...

recolic avatar Jun 23 '22 08:06 recolic

read this guide. and fix the DNS test: https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

Neilpang avatar Jun 23 '22 09:06 Neilpang

No. I have reverted all my code change. It means that this test does not pass even on the master branch.

I have carefully read the guide for 3 times, however, I still don't know what should I do to fix the master branch.

recolic avatar Jun 23 '22 09:06 recolic

why not do the steps in the guide ?

image

Neilpang avatar Jun 23 '22 09:06 Neilpang

Question: Is it a expected behavior that master branch will fail the pipeline?

I am not adding any new API, so most of the guide does not apply to an empty Pull Request.

recolic avatar Jun 23 '22 09:06 recolic

Question: Is it a expected behavior that master branch will fail the pipeline?

Yes

Neilpang avatar Jun 23 '22 09:06 Neilpang

Oh sorry for the confusion. Since it's expected, I will only focus on testing my new API.

I was just going to the wrong way. Thanks for your information

recolic avatar Jun 23 '22 09:06 recolic

Hi Neilpang,

After playing with the workflow for several days, I noticed a weird problem in the DNS workflow:

While running ./acme.sh --issue -d recolic-testing-acme.freemyip.com --debug --dns dns_freemyip on my machine, it adds a TXT record for _acme-challange.recolic-testing-acme.freemyip.com, and then verify it. It works pretty well.

However, the testing workflow is trying to add two TXT record to the same domain name. It's obviously not supported by freemyip.com, and it leads to a failure. I don't understand why it wants to add two TXT records to the same domain, and it's not the case for my local test. Do you have any suggestion about how to fix this?

image

local testing log (succeeded): https://paste.ee/p/GiLiY
github action log: https://github.com/recolic/acme.sh/runs/7038179168?check_suite_focus=true#step:5:219

recolic avatar Jun 24 '22 08:06 recolic

it was required to create wildcard domain.

you can define a new secret TEST_DNS_NO_WILDCARD=1 to disable it.

Neilpang avatar Jun 26 '22 00:06 Neilpang

Hey @Neilpang I have passed all tests and pipelines, and I have squashed my git commits. I believe it's ready for merge now!

Could you take a minute and review this PR? Thanks for your powerful help!

recolic avatar Jun 26 '22 16:06 recolic