acme.sh icon indicating copy to clipboard operation
acme.sh copied to clipboard

Added Conditions to call apache and created module to work with pdns Mysql backend.

Open danc403 opened this issue 7 years ago • 5 comments

acme.sh: Added apache2 and httpd command conditions to apachePath()

dns_pdnsMysql.sh: Calls pdns Mysql backend to verify Let's Encrypt.

dnsapi/README.md: Added section 5a describing usage of dns_pdnsMysql.sh

danc403 avatar Mar 03 '18 16:03 danc403

Sorry but I don't understand this error:

The command "if [ "$TRAVIS_OS_NAME" = "linux" ]; then git diff --exit-code && echo "shfmt OK" ; fi" exited with 1.

Can you explain what it means? All other tests seem to pass except this one. Thank You, Dan

danc403 avatar Mar 03 '18 18:03 danc403

please check this guide: https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide

Neilpang avatar Mar 06 '18 12:03 Neilpang

what is the difference with pdns api: https://github.com/Neilpang/acme.sh/tree/master/dnsapi#5-use-powerdns-embedded-api-to-automatically-issue-cert

Neilpang avatar Mar 10 '18 01:03 Neilpang

The changes in acme.sh are for backwards compatibility. httpd is the Apachectl equivalent on all my CentOS 7 machines.

I will look at the DNS script today. Made those changes on my phone but it may have not come out like I planned.

On Fri, Mar 9, 2018, 7:23 PM neil [email protected] wrote:

@Neilpang commented on this pull request.

In acme.sh https://github.com/Neilpang/acme.sh/pull/1325#discussion_r173605521:

@@ -2452,8 +2452,12 @@ _apachePath() { if ! _exists apachectl; then if _exists apache2ctl; then _APACHECTL="apache2ctl"

  • elif _exists apache2; then #added

why is this change needed ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Neilpang/acme.sh/pull/1325#pullrequestreview-102833597, or mute the thread https://github.com/notifications/unsubscribe-auth/AjMV1NCk_GeM5fsiOI31LodgNUExpqX4ks5tcysmgaJpZM4Sa-pJ .

danc403 avatar Mar 10 '18 11:03 danc403

The difference in pdns is also backwards compatible. Older versions had no api. It is only useful for rhel machines that still ship with older versions of pdns. Rhel 7 still only goes to pdns v3 without adding repository which many businesses won't allow.

On Sat, Mar 10, 2018, 5:31 AM Dan Carpenter [email protected] wrote:

The changes in acme.sh are for backwards compatibility. httpd is the Apachectl equivalent on all my CentOS 7 machines.

I will look at the DNS script today. Made those changes on my phone but it may have not come out like I planned.

On Fri, Mar 9, 2018, 7:23 PM neil [email protected] wrote:

@Neilpang commented on this pull request.

In acme.sh https://github.com/Neilpang/acme.sh/pull/1325#discussion_r173605521:

@@ -2452,8 +2452,12 @@ _apachePath() { if ! _exists apachectl; then if _exists apache2ctl; then _APACHECTL="apache2ctl"

  • elif _exists apache2; then #added

why is this change needed ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Neilpang/acme.sh/pull/1325#pullrequestreview-102833597, or mute the thread https://github.com/notifications/unsubscribe-auth/AjMV1NCk_GeM5fsiOI31LodgNUExpqX4ks5tcysmgaJpZM4Sa-pJ .

danc403 avatar Mar 10 '18 11:03 danc403