Marco

Results 5 comments of Marco

> 🤦🏽 Thanks for the catch @acmarco . Do you mind signing your commit? My commit is signed (i.e: "This commit was signed with the committer’s verified signature. ") ......

> hey @acmarco, thanks for the PR! here's what we mean by [signing your commits](https://docs.feast.dev/project/development-guide#signing-off-commits) > > also, is there a particular reason you're using Feast 0.22 instead of Feast...

> I'll approve this PR and cut a patch release (0.22.5) once it's in! thanks for taking the time to address this PR. I was just wondering when the 0.22.5...

> Actually this PR doesn't make sense for specifically 0.22. We dropped Python 3.7 support in 0.23 (numpy 1.22 also drops this), so this results in a failed release. Sorry,...

I suspect that the error is caused by the local module name `redis.py` shadowing the `redis` package module. I have not reproduced or confirmed this my suspicion, but we are...