jetfire icon indicating copy to clipboard operation
jetfire copied to clipboard

iOS13 Compatibility

Open JulzPolz opened this issue 6 years ago • 6 comments

There are a few new warnings as a result of iOS13.

The main culprit seems to be... 'SecTrustEvaluate' is deprecated: first deprecated in iOS 13.0

Screenshots of the code with these warnings... Screenshot 2019-10-01 at 15 43 46 Screenshot 2019-10-01 at 15 43 25

JulzPolz avatar Oct 01 '19 14:10 JulzPolz

Any thoughts on this @acmacalister ? Its just generally much better to have no warnings in the code so that developers are able to spot new warnings during coding instantly without having to read through a list of existing warnings. Thanks.

JulzPolz avatar Oct 03 '19 13:10 JulzPolz

Thanks for fixing this. Any idea when it will be pulled into master? Thanks.

JulzPolz avatar Oct 15 '19 11:10 JulzPolz

@ddaddy any news for when this will be hitting master?

JulzPolz avatar Nov 01 '19 16:11 JulzPolz

Sorry, I'm not the owner of this. I submitted the pull request but @acmacalister needs to pull it.

ddaddy avatar Nov 01 '19 16:11 ddaddy

Ok cool. Will wait for @acmacalister to merge into master then.

JulzPolz avatar Nov 01 '19 16:11 JulzPolz

There are 11 open pull requests open since 2015, and no commit on this repo for over 2 years. I'm guessing it's a dead repo.

Interestingly, Sonos just forked it: https://github.com/sonos/jetfire

themartorana avatar Nov 19 '19 20:11 themartorana