profiling icon indicating copy to clipboard operation
profiling copied to clipboard

WIP: Don't add additional scope when profile is not enabled

Open gwen-lg opened this issue 1 year ago • 0 comments

The additional scope break some clippy lint detection (like missing_errors_doc) This Fix #75

WIP: the change affect only when no profiling instrumentation is enabled. But if the puffin (by example) instrumentation is enabled, the problem is here again. And when I have tried remove the additional brace too in impl_block of profile-with-puffin, the macro failed with :

error: custom attribute panicked
 --> profiling/examples/simple.rs:8:1
  |
8 | #[profiling::all_functions]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = help: message: expected curly braces

gwen-lg avatar Aug 07 '24 14:08 gwen-lg