perf icon indicating copy to clipboard operation
perf copied to clipboard

Check for non-empty event buffer on perfhup

Open pwaller opened this issue 5 years ago • 4 comments

Previously, if poll returned HUP, we would immediately return ErrDisabled, but this means we could miss events if there are events waiting in the buffer.

Fixes: #23

pwaller avatar May 10 '20 12:05 pwaller

Please consider this patch carefully. I'm still not certain that this fixes all the underlying issues. I'll let you think about it before explaining what I understand, so that we each cover as much ground as possible :)

pwaller avatar May 10 '20 12:05 pwaller

Friendly ping. My memory of this is fading. I spent a fair amount of time trying to understand this at the time, and concluded this was the right thing to do. Without it, I recall seeing events missing from the ring buffer.

pwaller avatar Aug 31 '20 20:08 pwaller

Ping @acln0

pwaller avatar Nov 15 '20 19:11 pwaller

Ping, it would be nice to try and resolve this some time. Hope all is well.

pwaller avatar Jun 22 '23 19:06 pwaller