perf
perf copied to clipboard
Confusing code
This is only a minor suggestion, but I found this confusing:
https://github.com/acln0/perf/blob/239c48f711bc4741a1a6e4ab75edf78ca429a7cd/record_test.go#L219-L225
-
Variables/consts beginning with the name
err
are usually errors. -
It refers to testErrDisabledProcessExist which doesn't exist.
-
It's unclear from the comment which side of the branch is "in" something. Is it in the returning side, or the non-returning side? This might be a rare case where "early return" is a minor hinderance and perhaps it would be better to phrase it positively, and move the body of code out, to make it clear when the special condition matches:
func init() { if specialCondition { doSpecialCondition() } }