kbin-kes icon indicating copy to clipboard operation
kbin-kes copied to clipboard
verified publisher icon aclist

[BUG] mobile_cleanup's hide filter option is unclear

Open Pamasich opened this issue 10 months ago • 6 comments

Browser

Chromium-based

Script manager

Tampermonkey

KES version

4.3.0-beta.20

Describe the bug

Mobile Cleanup's Hide filter icon option currently hides the type filter specifically, the entire button. Looking at the code, this seems to be entirely by design.

However, the label gives no indication that only this filter is targeted, and the mention of "icon" makes it sound more like it's supposed to remove the icon only, not the entire button.

Looking at one of the remaining kbin instances, it seems the intention was to hide just the type filter specifically, but the entire filter. So imo the "icon" text should be dropped from the label and it should be mentioned that it applies to the type filter specifically.

Pamasich avatar Feb 17 '25 13:02 Pamasich

It might have been that these icons/filters had very little function in the original kbin. The author preferred to remove these dead icons. I agree that the wording should be changed.

I'm wondering if it even makes sense now to suppress these anymore. I tried making the view mobile size and enabling as many mods and settings as I could, but I didn't see anything interfering per se.

I do remember it was specifically a problem with some Samsung devices.

aclist avatar Feb 18 '25 19:02 aclist

Is there any difference between classic and compact view when in mobile mode?

aclist avatar Feb 27 '25 03:02 aclist

They do definitely have differences. Using Chromium's phone emulation mode for these.

Image Classic Mode

Image Compact Mode

Pamasich avatar Feb 27 '25 10:02 Pamasich

I think the original idea was probably, this is a simple preference, you're not going to switch back and forth. So once it's been configured, there's no need for the option to still be there all the time and take up space. If someone using the mod wants to change their preference, all they have to do is to temporarily turn the mod off.

Pamasich avatar Feb 27 '25 10:02 Pamasich

If that's the case, this should probably allow suppressing other icons. Also, what is that folder with a + on it in your view? Create a post? All I had by default on my end was:

Image

aclist avatar Feb 27 '25 20:02 aclist

Never mind, answered my own question by looking at the dropdown. I didn't expect the different dropdown options to have their own icons.

aclist avatar Feb 27 '25 20:02 aclist