kbin-kes icon indicating copy to clipboard operation
kbin-kes copied to clipboard

[BUG] Clicking (un)subscribe button in magazines index hides softblock button

Open aclist opened this issue 11 months ago • 5 comments

Browser

Firefox-based

Script manager

Tampermonkey

KES version

4.3.0-beta.8

Describe the bug

Clicking the (un)subscribe button in the magazines index redraws the contents of the .magazine__sub container which holds the buttons, and this causes the Softblock button to disappear (no actual effect on softblock state, just cosmetic).

aclist avatar Jan 31 '25 08:01 aclist

Additionally, this mod fails on mbin 1.8.0 because it looks for .options__main a[href="/magazines/abandoned"] in order to insert itself adjacent to this element, rather than simply looking for the last item in the magazines navbar.

aclist avatar Feb 12 '25 11:02 aclist

Additionally, this mod fails on mbin 1.8.0 because it looks for .options__main a[href="/magazines/abandoned"] in order to insert itself adjacent to this element, rather than simply looking for the last item in the magazines navbar.

It seems to work for me on kbin.earth, which is supposed to be running 1.8.0: Image

Pamasich avatar Feb 18 '25 10:02 Pamasich

When not logged in on kbin.earth, the last tab is "Active" for me. There's no "Abandoned".

aclist avatar Feb 18 '25 10:02 aclist

Oh, that's interesting. Didn't think Abandoned would be exclusive to logged in users.

Pamasich avatar Feb 18 '25 10:02 Pamasich

Yes, it's a strange design choice, but it is what it is.

I'm going to wait to finish this bugfix until your PR for loadMags() is done, since softblock depends on it.

aclist avatar Feb 21 '25 19:02 aclist