Austin Clements
Austin Clements
@diegomontoya, surely those are already on the heap? There's no point in using atomic operations on variables unless they're shared, and if they're shared they must be in the heap....
> 2022-11-03 17:41 linux-amd64-staticlockranking go@5c0d314a os/signal.TestSignalTrace ([log](https://build.golang.org/log/af083d40156b011db2e0cadd6040692cf579967c)) This is #56554. I've added a pattern to that issue.
One more interesting goroutine from that trace: ``` goroutine 23250 [runnable]: runtime.goexit1() /workdir/go/src/runtime/proc.go:3616 +0x54 fp=0xc000750fe0 sp=0xc000750fd8 pc=0x448934 runtime.goexit() /workdir/go/src/runtime/asm_amd64.s:1599 +0x6 fp=0xc000750fe8 sp=0xc000750fe0 pc=0x47a766 created by runtime_test.TestDebugCallUnsafePoint ```
> This assumes that the GC is non-moving. I don't think it does. Broadly, there are two solutions to pointer hashing in a moving GC: 1. Rehash all objects that...
*Edit 2024-06-05: Tried to clarify table.* We were discussing this in the Google compiler/runtime team and had some more thoughts. > Even for today's GC, there's the movement due to...
> For clarity, I think the key would not escape if it is for example an integer type or struct of integers, even under the simple implementation? That's right. Because...
@Merovius , I believe I addressed that in https://github.com/golang/go/issues/54670#issuecomment-1716052653. TL;DR, it's an interaction we'd need to account for, but it's ultimately fine, and we'd probably need to deal with this...
> In your table you have "string w/ 2i" and "string w/ 2ii". What is "2i" and "2ii"? In retrospect, the way I wrote that was incredibly unclear! That was...
Thanks for all of this work @qmuntal ! Is there more to be done here, or can we close this issue at this point?
> Is E, T the standard order in other languages for the comparison arguments in a call like this? These are the closest equivalents I can find in other languages:...