deprem-yardim-frontend icon indicating copy to clipboard operation
deprem-yardim-frontend copied to clipboard

bug: Switching between multiple locations, does not update the url

Open siniradam opened this issue 2 years ago • 4 comments

Bug Definition

When there are multiple pins on same location there is a swap button at the bottom of the drawer. With these buttons switching between locations does not update the current url.

-- Please add discord contact information ** discord username: tinman#7219 **

## Bug environment rc.afetharita.com afetharita.com

Describe how you are producing the bug step by step

Go to this URL; https://rc.afetharita.com/en?lat=37.076078833957666&lng=36.24636143445969&zoom=18&id=552626

Screenshot 2023-02-12 at 9 41 24 PM

Click on the pin shown in the image, switch to next pin via buttons located at the bottom of the drawer.

Expected Behaviour

Should update the url.

Desktop Information

  • Operating System: osx
  • Browser any

siniradam avatar Feb 13 '23 05:02 siniradam

When you select another pin, is the information updated on the map?

There was a discussion on obfuscating long the URL parameters. So this may not be a relevant issue soon as long as it is not related to data accuracy.

nazdezar avatar Feb 13 '23 05:02 nazdezar

I'm not sure what you mean by that. If you check sc below you'll see what I mean by that. If I can't see the url I can't share it.

Screen Recording 2023-02-12 at 9 53 50 PM

Another issue is that, if a pin is loaded via direct URL, second data doesn't appear on the drawer.

eg: https://rc.afetharita.com/en?lat=37.07601037389749&lng=36.24790370464326&zoom=18&id=552626

siniradam avatar Feb 13 '23 05:02 siniradam

URL stays the same when we change the id.

CyhnYldz avatar Feb 13 '23 10:02 CyhnYldz

if no one is working i can handle it

muratyilmaz743 avatar Feb 13 '23 13:02 muratyilmaz743

This issue seems to be fixed in production. Can someone else test the issue and if it is fixed, close the issue?

mertkaya1033 avatar Feb 16 '23 01:02 mertkaya1033

It is fixed on Prod and RC. 👍

CyhnYldz avatar Feb 16 '23 07:02 CyhnYldz