deprem-yardim-backend icon indicating copy to clipboard operation
deprem-yardim-backend copied to clipboard

added address evaluation to handle address collisions

Open younver opened this issue 2 years ago • 0 comments

Description

  • trendyol_bff.py now returns all of the addresses extracted from Trendyol API.
  • address_evaluator.py finds and returns the optimal (closest to the busiest area) address from provided addresses.
  • address_api.py evaluates the address just after calling Trendyol API.

Related Issue

https://github.com/acikkaynak/deprem-yardim-backend/issues/115

Motivation and Context

  • I've seen that Istanbul had around 80 cases, which has no relation with the latest earthquakes in Turkey.
  • Previously trendyol_bff.py get the first location from Trendyol API which may occur some address collision cases as provided below.
  • This commit fixes https://github.com/acikkaynak/deprem-yardim-frontend/issues/494 and the 2nd case of https://github.com/acikkaynak/deprem-yardim-backend/issues/115
  • Now the same input generates possibly more accurate address {'address': 'Necip Fazıl', 'latitude': 36.8497349, 'longitude': 36.2323796, 'northeast_lat': 36.85111792989272, 'northeast_lng': 36.23378112989273, 'southwest_lat': 36.84841827010728, 'southwest_lng': 36.23108147010728, 'formatted_address': 'Yeşil, 31600 Dörtyol/Hatay, Türkiye', 'is_resolved': True} Screenshot 2023-02-08 at 12 23 42 Screenshot 2023-02-08 at 22 21 14

younver avatar Feb 08 '23 19:02 younver