ddsp_pytorch icon indicating copy to clipboard operation
ddsp_pytorch copied to clipboard

Published 20 hours ago • verified publisher icon acids-ircam

extract_loudness: Fixing #31

Open nielsrolf opened this issue 3 years ago • 0 comments

Here is a version of extract_loudness that is almost a 1:1 copy of the fixed version of the magenta/ddsp compute_loudness. The changes are mostly:

  • take mean in amplitude scale, then convert back to db
  • do everything in PyTorch instead of librosa/numpy, thereby making it differentiable In contrast to magenta/ddsp, this version does not have dynamic range and ref_db, but I don't understand the concepts behind those and doubt that they are necessary. There seem to be small numerical errors that prevent the curve from being 100% smooth, but this is something one can live with I hope: image

nielsrolf avatar Nov 26 '21 21:11 nielsrolf