Ava Chow

Results 131 issues of Ava Chow

The `blank` wallet flag is used to indicate that the wallet intentionally does not have any keys, scripts, or descriptors, and it prevents the automatic generation of those things for...

Wallet

This PR adds a signature to the encrypted key records (`ckey` and `walletdescriptorckey`) which acts as an additional checksum. The signature is produced by the private key, and signs the...

Wallet

This PR changes DescriptorScriptPubKeyMan to no longer handle relevant keys directly. Instead all keys for all DescriptorSPKMs will be handled by a new `KeyManager` class which exists within `CWallet` (a...

Wallet
Descriptors

We've long since moved away from using the legacy address type unless the user explicitly wants it, so we should not re-introduce using it as change automatically.

Wallet

Currently `FundTransaction` handles transaction locktime and preset input data by extracting the selected inputs and change output from `CreateTransaction`'s results. This means that `CreateTransaction` is actually unaware of any user...

Wallet
RPC/REST/ZMQ

if a transaction is being funded that has an external input, and that input's parent is also in the wallet, we will fail to detect that and fail to fund...

Wallet

This PR adds a new `migratewallet` RPC which migrates a legacy wallet to a descriptor wallet. Migrated wallets will need a new backup. If a wallet has watchonly stuff in...

Wallet
RPC/REST/ZMQ

Adds a unique id for each wallet that is saved in a new "walletid" record. For compatibility, wallets using BDB will use the BDB generated id. All other wallets will...

Wallet

It is convenient to have a descriptor which specifies both receiving and change addresses in a single string. However, as discussed in https://github.com/bitcoin/bitcoin/issues/17190#issuecomment-895515768, it is not feasible to use a...

Wallet
RPC/REST/ZMQ
Descriptors