lein-parent icon indicating copy to clipboard operation
lein-parent copied to clipboard

Merge all

Open Frozenlock opened this issue 5 years ago • 6 comments

Add the ability to merge ALL properties (except the name) from a parent project without having to manually update the inherit field in all the children.

How to use:

Add leiningen.parent/all as an inherit keyword.

  :parent-project {:coords  ...
                   :inherit [:leiningen.parent/all]} ; <---

Frozenlock avatar Jun 21 '20 20:06 Frozenlock

Thanks for your contribution. I'll merge your PRs and release a new version as soon as I can.

Do you think there's a chance that you may have forgotten to check in a new with_parent_inherit_all sample/test project? I'm getting the following errors running lein test.

lein test

lein test leiningen.t-parent

lein test :only leiningen.t-parent/inherited-values-test

ERROR in (inherited-values-test) (project.clj:1046)
Uncaught exception, not in assertion.
expected: nil
  actual: java.lang.Exception: Error loading ./dev-resources/t_parent/samples/children/with_parent_inherit_all/project.clj
 at leiningen.core.project$read_raw$fn__7295.invoke (project.clj:1046)
    leiningen.core.project$read_raw.invokeStatic (project.clj:1040)
    leiningen.core.project$read_raw.invoke (project.clj:1036)
    leiningen.core.project$read.invokeStatic (project.clj:1057)
    leiningen.core.project$read.invoke (project.clj:1054)
    leiningen.core.project$read.invokeStatic (project.clj:1058)
    leiningen.core.project$read.invoke (project.clj:1054)
...
Ran 2 tests containing 10 assertions.
0 failures, 1 errors.
Tests failed.

achin avatar Jun 21 '20 20:06 achin

You are right, I have some new unchecked files. I'll fix this ASAP.

Frozenlock avatar Jun 21 '20 20:06 Frozenlock

I have another PR I'm working on, so you might want to wait a little before a new release.

Frozenlock avatar Jun 21 '20 21:06 Frozenlock

Thanks.

On Sun, Jun 21, 2020, 5:00 PM Frozenlock [email protected] wrote:

I have another PR I'm working on, so you might want to wait a little before a new release.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/achin/lein-parent/pull/24#issuecomment-647180971, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAATZAUNHDG6EVR3URGHPSDRXZYGFANCNFSM4OEAI6BA .

achin avatar Jun 21 '20 21:06 achin

My next PR might be more involved with a higher risk of conflict if the pending PRs are not accepted or require revisions.

When you'll have time, could you give a look at the pending PRs and merge them (without releasing a new version yet)?

Frozenlock avatar Jun 22 '20 18:06 Frozenlock

Sure. I'd be happy to, but I may not get to them until the weekend. If you prefer to put everything in one, big PR, I'd be happy to merge that, too.

On Mon, Jun 22, 2020 at 2:14 PM Frozenlock [email protected] wrote:

My next PR might be more involved with a higher risk of conflict if the pending PRs are not accepted or require revisions.

When you'll have time, could you give a look at the pending PRs and merge them (without releasing a new version yet)?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/achin/lein-parent/pull/24#issuecomment-647691665, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAATZAVFHOTG6VGSDF2AKYDRX6NPFANCNFSM4OEAI6BA .

achin avatar Jun 22 '20 18:06 achin