Sagar Mishra

Results 71 comments of Sagar Mishra

How long before this can be merged? I'd like to use the 'official' feature :)

@Conengmo I appreciate your input on the error. It was an oversight on my end. This PR should be good to go.

Hey @fkiraly thanks for offering any assistance. Before we move on to adding new tests for nested pipelines, I have to solve the current test failures. The current changes give...

I'm sorry for missing your comments and completing this PR, I'll get back to your comments as soon as I can and resolve the issue within the rest of this...

So, all the current tests pass now (the one odd error seems unrelated and documented in #5307) which means the current implementation doesn't break any contract. I'll go ahead and...

> my intuition tells me that _get_params_for_sklearn_base_estimator from within the pipeline plugin is redundant with _gfp_nested_sklearn_plugin. It also does not seems to recurse, unlike the latter. Is that a mistake?...

After a bit of thinking, I agree with both of your assessments. Let me first make this external to the base class and then I'll incorporate these two points in...

So here's my plan of action: 1. This PR: Let us refactor the existing plugins into a different file and add a document on how to extend it. It should...