acheronfail

Results 89 comments of acheronfail

Here's the RGB Fade using `color_wheel` instead. I think it still looks good, plus using `color_wheel` let me remove a almost all of the code for the previous fade implementation...

> Definitely not necessary for this PR, but would you maybe like to give it a try? Ideally it should go through the rainbow in a consistent way. yep, in...

After trying out a bunch of different ways to interpolate the colours (tried smoothing RGB, tried HSV values, etc) I found that this provides a much more "natural" looking fade...

Alrighty, I separated the commits, and had a crack at creating an optimised version which avoids the trig functions, and instead uses a bunch of multiplications with a few divisions....

Oh, awesome results! > Thinking about this, it's not correct, or rather not trivial to do right. But the old "run in a loop and measure time" can be done...

> Your Taylor Series is not approximating sine, it's approximating a sqrt(sine(...)), quite a different function. I kinda assumed if you would just use sine, that would render the base...

Oh nice, I'll have to learn how to do that with Blender, being able to visualise that is really cool! Tonight I'll try out this code on the VESC and...

@aeraglyx I had a crack at implementing it, this was my code: ```c // Generate colors using the OKLAB colorspace, see: https://bottosson.github.io/posts/oklab/ static uint32_t color_wheel(uint8_t pos) { // See: https://oklch.com/#75,0.13,360,100...

> Why is the sRGB transform at the end needed? Perhaps I implemented incorrectly at the beginning, but I found that the original transformation caused very dim and unpleasant effects...

Sorry, I don't have the time right now to commit to finishing this at the moment (that, and the LEDs on my board aren't working very well either, so that...