Abhishek Chanda comments

Results 23 comments of


                                            Abhishek Chanda

Add a changelog

That makes sense. I will add a changelog, either automated or manual, from the next release onwards.

[Bug]: The CustomResourceDefinition "poolers.postgresql.cnpg.io" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

@remotejob try a server side apply ``` k apply -f https://github.com/cloudnative-pg/cloudnative-pg/releases/download/v1.22.3/cnpg-1.22.3.yaml --server-side ```

Show that the CRDTs work across machines.

@russwyte you're correct that these are not exactly serializable across a network at this moment. That's why the examples say nothing about that. However, that should be pretty easy to...

feat: allow setting a service type and annotations for a pooler resource

Todo: - [x] Make annotations optional - [x] More tests

feat: allow setting a service type and annotations for a pooler resource

@phisco what usecase do you have in mind to enable adding to selectors and ports? I was thinking we don't enable adding to these and keep these internal. Later, if...

feat: allow setting a service type and annotations for a pooler resource

@phisco done and pushed, PTAL 🙏

feat: allow setting a service type and annotations for a pooler resource

@phisco I checked that I can apply these CRDs on a kind cluster. This should be ready for review now. ``` ╭─Abhishek@AbhishekMacbookPro ~/src/cloudnative-pg ‹external-pooler› ╰─$ kubectl apply -f config/crd/bases/ customresourcedefinition.apiextensions.k8s.io/backups.postgresql.cnpg.io...