ember-cli-deploy-original icon indicating copy to clipboard operation
ember-cli-deploy-original copied to clipboard

Add index to redis with branch name as key as well as commit hash

Open achambers opened this issue 10 years ago • 3 comments

As well as deploying the index.html to Redis with the git commit as the key, upload it with the branch-name as a key as well. This way we can access a branch based on branch name as well as particular commits

achambers avatar Oct 28 '14 20:10 achambers

Hey. Could u pls roughly describe your expectations of how this feature is suppose to work? 'branch' or 'hash' can be passed via cli interface, right ? Thanks.

pavloo avatar Jan 25 '15 21:01 pavloo

Hi @sol1dus . This is probably now an issue for the https://github.com/achambers/ember-cli-deploy-redis-index-adapter repo. The idea being that, as well as adding the index.html for the current git hash, it also adds it for the current branch.

Haven't thought too far down this path so totally open for discussion but thought it would be handy to also be able to see deployments based on a branch name. So, instead of my-site.com?key=abc3425 I could also go to my-site.com?key=feature-branch.

Now that the upload of the index.html file has been offloaded to the adapter repo (above), it's really it's responsibility to do this.

Thoughts?

achambers avatar Feb 02 '15 20:02 achambers

@achambers okay, when I'll have some developments, I issue PR against adapter to have discussions around them. thanks.

pavloo avatar Feb 03 '15 09:02 pavloo