Adam C. Foltzer

Results 47 comments of Adam C. Foltzer

Gotcha, thanks for the extra context! It all makes sense now, and I can understand why you'd want that capability. I'll do some more thinking on it, but at first...

Sorry this is all taking so long, but this part is implemented in #454 >API to attach/detach signal handlers - This will allow the embedding process to figure out when...

We're already in the process of reworking `lucet-wasi` to use the shared [wasi-common](https://github.com/CraneStation/wasi-common) hostcall implementations, so I wouldn't recommend working on a patch until that lands, in order to avoid...

On the API design side, I believe the plan is still to have WASI be divided into distinct modules, eg `wasi-fs`, `wasi-rand`. I expect there will be a module specifically...

If I understand correctly, you want to be able to add a function to the Wasm table, which means you need a function pointer and the signature index (the `func`...

@shravanrn I think the two extensions you propose would fall pretty naturally out of implementing full support for mutable tables under the reference types proposal. You'd be able to import...

I would say this is a bug, as sometimes the distinction between no path and root path is important. For example, when calculating the effective request URI per RFC 7230...

> You can represent it: > > ```rust > Uri::from_parts(Parts { > scheme: Some(Scheme::HTTPS), > authority: Some(Authority::from_static("localhost")), > path_and_query: None, > }) > ``` Since `uri::Parts` has a private field,...

It turns out that `Uri::from_parts` will return an error if `scheme` is `Some` but `path_and_query` is `None`.

Digging into this a bit more, there are a few places in the code that probably need to be addressed to fix this. First, `Uri::from_parts` contains a check that doesn't...