cbrain
cbrain copied to clipboard
flag to copy input data to work folder
This to reduce corruption of input data and race conditions with input mutating scientific tools, see #1281 for description
a test boutiques is available at https://github.com/MontrealSergiy/cbrain-plugins-test/blob/copydata/boutiques_descriptors/copy_flag_demo.json
I don't really want a new attribute in the tool config structure, rather I want a simple implementation that just copies files when make_available is called with a new option:
def make_available(userfile, file_path, userfile_sub_path = nil, start_dir = nil, copy_files = false)
On the Boutiques descriptor side, all I want is support for:
"custom": {
"cbrain:full-copy-input-files": [ "inputid1", "inputid2", "inputid3" ],
- BTQ integrator to set copy_files
Note that I see several uses of make_available, besides the BTQ integrator e.g. such as boutiques_input_subdir_maker, bids_app_maker
Should I address them too? Would people continue to use it in modules ?
perhaps, it safer to pull property automatically, maybe yet another parameter copy_input_auto
= true?
Looks like rebase gone wrong still working
Ok, changed as requested ( without modules or old style integrator)
Please also look at supporting this option in the original Boutiques integrator. This code only supports the new integrator. If it's too complicated, let me know. We don't use the old integrator anymore, so maybe it's not worth it.
rebased