Loris icon indicating copy to clipboard operation
Loris copied to clipboard

[issue_tracker] Fix typo & Cleanup close permission

Open CamilleBeau opened this issue 8 months ago • 2 comments

Brief summary of changes

This PR modifies the code in modules/issue_tracker/php/edit.class.inc where the drop-down values are set to accommodate for the new permissions that were added in 27. With this code, the "close" option is added to the statuses drop-down in cases where a user has the appropriate permission to close the current issue, and it is not added otherwise.

This PR also fixes a typo in a variable from hasPartialAcess to hasPartialAccess

  • [ ] Have you updated related documentation?

Testing instructions (if applicable)

  1. Grant a user the "own issue" Issue tracker permission
  2. Ensure that the user can only view and close their own issues
  3. Add the permission to view all issues to the user
  4. They should now be able to view all issues, but still only able to close their own
  5. Add the permission to close own sites' issues to the user
  6. They should now be able to view all issues, but only close issues from their sites
  7. Add the permission to close all issues
  8. The user should now be able to close all issues, including issues at sites that they do not have.

Link(s) to related issue(s)

  • Resolves #NO ISSUE

CamilleBeau avatar Apr 16 '25 14:04 CamilleBeau

@CamilleBeau update description to have more details

skarya22 avatar May 13 '25 15:05 skarya22

LGTM

adamdaudrich avatar May 13 '25 19:05 adamdaudrich