Loris icon indicating copy to clipboard operation
Loris copied to clipboard

[create_timepoint] Add error swal

Open victori444 opened this issue 1 year ago • 2 comments

Brief summary of changes

In the Create Timepoint module, if there was a PHP error upon submission, the entered data would not save without any error message. This adds an error swal if a PHP error occurs

Testing instructions (if applicable)

  1. Revert the changes made in this PR to cause a PHP error
  2. In the Create Timepoint module of any candidate, create a new valid visit
  3. Submit and verify that the error swal appears
  4. Restore the changes in the create_timepoint class (such that there are no PHP errors) and check that new visits can be created

Link(s) to related issue(s)

  • Resolves #9358

victori444 avatar Dec 04 '24 20:12 victori444

I'm trying to test this but I'm still getting a success swal.

Screenshot

driusan avatar Dec 05 '24 16:12 driusan

In conclusion, when we got a PHP error, the swal is not showing it so the PR still need work since this was the goal image

racostas avatar Oct 30 '25 15:10 racostas