Loris icon indicating copy to clipboard operation
Loris copied to clipboard

Published 20 hours ago • verified publisher icon aces

[media] Permission names need revising

Open jeffersoncasimir opened this issue 11 months ago • 3 comments

The media module permissions are the following:

  • Media: Edit/Upload/Delete Candidate Media Files
  • Media: View/Download Candidate Media Files

Users with Media: View/Download Candidate Media Files are able to view files but do not have the option to download them; even their own uploads.

Only users with the Media: Edit/Upload/Delete Candidate Media Files can download. However, I do not see a Delete feature on the v26 VM. There is a Hide File feature which can be listed instead.

The current names are not accurately reflecting the permission scopes.

jeffersoncasimir avatar Mar 25 '24 16:03 jeffersoncasimir

Some comments:

  1. The issue of the user been able to see the "file name" and not to download it seems to be solved in 25 by PR. https://github.com/aces/Loris/pull/8671 Let's try to merge it in the 26 code-base.

  2. I don't seen we can really "Delete" file. So the name of this permission needs to change to Edit/Upload/HIde.

racostas avatar Apr 25 '24 15:04 racostas

Wil take care !

racostas avatar Apr 25 '24 15:04 racostas

I tried to merge 25 into 26 and the diff did not include that PR.

It's possible that it was eatten by a previously badly resolved merge. can you just re-send the change to main?

driusan avatar Apr 25 '24 15:04 driusan