Loris
Loris copied to clipboard
[electrophysiology_browser] Replace Physiological Annotations with Events
This PR aims to improve the current compliance to the BIDS standard. Loris-MRI counterpart: #1041 Partially addresses #8910.
This replaces references to annotation
files with references to event
files.
This PR deletes *_annotation_*
tables. The corresponding required event tables already exist.
+minor improvements to the EventManager
and AnnotationForm
components.
This PR brings in the following limitations:
- Events can no longer be created via the interface (support coming soon)
- Events can be modified, but the currently supported fields are by default
read-only
ordisabled
(Name and time) - HED tag support is extremely limited (better support in imminent PR: #9033)
~TODO: Raisinbread modifications~
TODO: Get official server-side solution + Add to documentation.
- [ ] Determine required request time limit
- [ ] Determine required memory allocation limit
- [ ] Determine procedure for increasing when needed
Both of the above needed to be increased for certain requests.
@regisoc can you review this?
I will put that here so we do not forget them. Note after tests:
- Event download button disabled or not working.
- Error
epoch.properties is undefined
following that process:- open event panel
- edit one event
- submit this event
- close the event submit with the top-right "x".
@jeffersoncasimir let me know if you need another round of test this morning.