Loris icon indicating copy to clipboard operation
Loris copied to clipboard

Replace DoB/EDC with 'Derived Age'/'EDC Age'

Open GeorgeMurad opened this issue 1 year ago • 10 comments

Brief summary of changes

  • [ ] Have you updated related documentation?

Testing instructions (if applicable)

Link(s) to related issue(s)

  • Resolves # (Reference the issue this fixes, if any.)

GeorgeMurad avatar Nov 30 '23 21:11 GeorgeMurad

@GeorgeMurad please try to replace '90000' to '300001' in /test/test_instrument/test_instrumentTest.php.

kongtiaowang avatar Dec 04 '23 15:12 kongtiaowang

@GeorgeMurad https://github.com/aces/Loris/blob/main/modules/candidate_profile/test/candidate_profileTest.php line 100 and line 123 90000 to 300001

kongtiaowang avatar Dec 04 '23 20:12 kongtiaowang

@GeorgeMurad please revert all change '90000' to '300001' in /test/test_instrument/test_instrumentTest.php.

kongtiaowang avatar Dec 05 '23 15:12 kongtiaowang

@kongtiaowang I did replace all 900000 to 300001 in /test/test_instrument/test_instrumentTest.php.

GeorgeMurad avatar Dec 05 '23 15:12 GeorgeMurad

@GeorgeMurad modify these two files modules/candidate_profile/test/candidate_profileTest.php modules/instrument_list/php/instrument_list.class.inc from this PR https://github.com/kongtiaowang/Loris/pull/380

kongtiaowang avatar Dec 06 '23 18:12 kongtiaowang

[client 192.168.122.1:47966] [CRITICAL] /var/www/loris/modules/instrument_list/php/instrument_list.class.inc:307: Uncaught TypeError: strtotime(): Argument #1 ($datetime) must be of type string, null given in /var/www/loris/modules/instrument_list/php/instrument_list.class.inc:307\nStack trace:\n#0 /var/www/loris/modules/instrument_list/php/instrument_list.class.inc(307): strtotime()\n#1 /var/www/loris/php/libraries/NDB_Page.class.inc(741): LORIS\instrument_list\Instrument_List->setup()\n#2 /var/www/loris/src/Middleware/UserPageDecorationMiddleware.php(247): NDB_Page->handle()\n#3 /var/www/loris/src/Middleware/PageDecorationMiddleware.php(58): LORIS\Middleware\UserPageDecorationMiddleware->process()\n#4 /var/www/loris/php/libraries/NDB_Page.class.inc(725): LORIS\Middleware\PageDecorationMiddleware->process()\n#5 /var/www/loris/modules/instrument_list/php/instrument_list.class.inc(154): NDB_Page->process()\n#6 /var/www/loris/php/libraries/Module.class.inc(321): LORIS\instrument_list\Instrument_List->process()\n#7 /var/www/loris/modules/instrument_list/php/module.class.inc(46): Module->handle()\n#8 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\instrument_list\Module->handle()\n#9 /var/www/loris/src/Middleware/AuthMiddleware.php(63): LORIS\Middleware\ResponseGenerator->process()\n#10 /var/www/loris/src/Router/ModuleRouter.php(74): LORIS\Middleware\AuthMiddleware->process()\n#11 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(54): LORIS\Router\ModuleRouter->handle()\n#12 /var/www/loris/src/Router/BaseRouter.php(132): LORIS\Middleware\ExceptionHandlingMiddleware->process()\n#13 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\Router\BaseRouter->handle()\n#14 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\Middleware\ResponseGenerator->process()\n#15 /var/www/loris/htdocs/index.php(55): LORIS\Middleware\ContentLength->process()\n#16 {main}\n thrown, referer: https://test-dev-250.loris.ca/288206/

kongtiaowang avatar Dec 14 '23 19:12 kongtiaowang

--- a/test/test_instrument/test_instrumentTest.php +++ b/test/test_instrument/test_instrumentTest.php @@ -34,7 +34,9 @@ class TestInstrumentTestIntegrationTest extends LorisIntegrationTest 'Active' => 'Y', 'UserID' => 1, 'Entity_type' => 'Human', '-' 'Sex' => 'Female' '+' 'Sex' => 'Female', '+' 'DoB' => '2003-12-12', '+' 'EDC' => '2003-12-12'

kongtiaowang avatar Dec 15 '23 14:12 kongtiaowang

https://github.com/kongtiaowang/Loris/pull/380/files#diff-60551da7d87fb90eb78cba7808e8435368c2da98ef895e37e7ceedd62569df48

kongtiaowang avatar Feb 27 '24 17:02 kongtiaowang

@GeorgeMurad modify this file 1 . test/test_instrument/test_instrumentTest.php from this PR https://github.com/kongtiaowang/Loris/pull/380 2 . raisinbread/test/api/LorisApiInstruments_v0_0_3_Test.php in this file change 900000 to 115788

kongtiaowang avatar Apr 03 '24 14:04 kongtiaowang

@GeorgeMurad I have modified the files. Could you please perform the manual test to confirm that the changes are correct?

kongtiaowang avatar Apr 16 '24 18:04 kongtiaowang