[Feedback] Fix typo in getSummaryOfThreads

[CamilleBeau]

Brief summary of changes

I had looked into the suspected bug and confirmed that it is indeed a bug.

This PR fixes the BVL Feedback summary in instruments by taking the commentID for query params from the array _feedbackObjectInfo instead of _feedbackCandidateProfileInfo, which only included candidate specific data instead of instrument specific data.

• [x] Have you updated related documentation?

Testing instructions (if applicable)

1. Outside of this PR, navigate to an instrument that has at least one feedback comment.
2. Look at the feedback for that instrument, and check the feedback summary at the top of the window. Notice that it is indicated that there is no feedback
3. Load this PR and refresh the page.
4. Notice that the summary exists and holds accurate information

[miladheshmati]

As I check out the PR and do a make dev, I'm getting a 500 error:

[Mon Jan 15 09:26:00.037402 2024] [php:notice] [pid 104055] [client 192.168.122.1:54428] electrophysiology_uploader is missing Module class #0 /var/www/loris/src/LorisInstance.php(79): Module::factory()\n#1 /var/www/loris/src/LorisInstance.php(111): LORIS\\LorisInstance->getActiveModules()\n#2 /var/www/loris/src/Router/BaseRouter.php(108): LORIS\\LorisInstance->hasModule()\n#3 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#4 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#5 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#6 {main}
[Mon Jan 15 09:26:00.201475 2024] [php:notice] [pid 104055] [client 192.168.122.1:54428] electrophysiology_uploader is missing Module class #0 /var/www/loris/php/libraries/Module.class.inc(63): Module::factory()\n#1 /var/www/loris/modules/dashboard/php/dashboard.class.inc(86): Module::getActiveModules()\n#2 /var/www/loris/php/libraries/Module.class.inc(289): LORIS\\dashboard\\Dashboard->__construct()\n#3 /var/www/loris/php/libraries/Module.class.inc(366): Module->loadPage()\n#4 /var/www/loris/src/Middleware/ResponseGenerator.php(50): Module->handle()\n#5 /var/www/loris/src/Middleware/AuthMiddleware.php(63): LORIS\\Middleware\\ResponseGenerator->process()\n#6 /var/www/loris/src/Router/ModuleRouter.php(74): LORIS\\Middleware\\AuthMiddleware->process()\n#7 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(54): LORIS\\Router\\ModuleRouter->handle()\n#8 /var/www/loris/src/Router/BaseRouter.php(133): LORIS\\Middleware\\ExceptionHandlingMiddleware->process()\n#9 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#10 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#11 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#12 {main}
[Mon Jan 15 09:26:00.396859 2024] [php:notice] [pid 104055] [client 192.168.122.1:54428] electrophysiology_uploader is missing Module class #0 /var/www/loris/php/libraries/Module.class.inc(63): Module::factory()\n#1 /var/www/loris/modules/dashboard/php/module.class.inc(140): Module::getActiveModules()\n#2 /var/www/loris/modules/dashboard/php/module.class.inc(58): LORIS\\dashboard\\Module->_getTasksWidget()\n#3 /var/www/loris/modules/dashboard/php/dashboard.class.inc(92): LORIS\\dashboard\\Module->getWidgets()\n#4 /var/www/loris/php/libraries/Module.class.inc(289): LORIS\\dashboard\\Dashboard->__construct()\n#5 /var/www/loris/php/libraries/Module.class.inc(366): Module->loadPage()\n#6 /var/www/loris/src/Middleware/ResponseGenerator.php(50): Module->handle()\n#7 /var/www/loris/src/Middleware/AuthMiddleware.php(63): LORIS\\Middleware\\ResponseGenerator->process()\n#8 /var/www/loris/src/Router/ModuleRouter.php(74): LORIS\\Middleware\\AuthMiddleware->process()\n#9 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(54): LORIS\\Router\\ModuleRouter->handle()\n#10 /var/www/loris/src/Router/BaseRouter.php(133): LORIS\\Middleware\\ExceptionHandlingMiddleware->process()\n#11 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#12 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#13 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#14 {main}
[Mon Jan 15 09:26:00.536259 2024] [php:notice] [pid 104055] [client 192.168.122.1:54428] electrophysiology_uploader is missing Module class #0 /var/www/loris/src/LorisInstance.php(79): Module::factory()\n#1 /var/www/loris/src/Middleware/UserPageDecorationMiddleware.php(59): LORIS\\LorisInstance->getActiveModules()\n#2 /var/www/loris/src/Middleware/PageDecorationMiddleware.php(57): LORIS\\Middleware\\UserPageDecorationMiddleware->process()\n#3 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(83): LORIS\\Middleware\\PageDecorationMiddleware->process()\n#4 /var/www/loris/src/Router/BaseRouter.php(133): LORIS\\Middleware\\ExceptionHandlingMiddleware->process()\n#5 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#6 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#7 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#8 {main}
[Mon Jan 15 09:26:00.546578 2024] [php:error] [pid 104055] [client 192.168.122.1:54428] PHP Fatal error:  Uncaught ConfigurationException: Config setting css does not exist in database in /var/www/loris/php/libraries/NDB_Config.class.inc:303\nStack trace:\n#0 /var/www/loris/php/libraries/NDB_Config.class.inc(415): NDB_Config->getSettingFromDB()\n#1 /var/www/loris/src/Middleware/UserPageDecorationMiddleware.php(136): NDB_Config->getSetting()\n#2 /var/www/loris/src/Middleware/PageDecorationMiddleware.php(57): LORIS\\Middleware\\UserPageDecorationMiddleware->process()\n#3 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(83): LORIS\\Middleware\\PageDecorationMiddleware->process()\n#4 /var/www/loris/src/Router/BaseRouter.php(133): LORIS\\Middleware\\ExceptionHandlingMiddleware->process()\n#5 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#6 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#7 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#8 {main}\n  thrown in /var/www/loris/php/libraries/NDB_Config.class.inc on line 303

[miladheshmati]

[Thu Jan 25 11:56:31.424593 2024] [php:notice] [pid 37075] [client 192.168.122.1:36620] electrophysiology_uploader is missing Module class #0 /var/www/loris/src/LorisInstance.php(79): Module::factory()\n#1 /var/www/loris/src/LorisInstance.php(111): LORIS\\LorisInstance->getActiveModules()\n#2 /var/www/loris/src/Router/BaseRouter.php(108): LORIS\\LorisInstance->hasModule()\n#3 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#4 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#5 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#6 {main}
[Thu Jan 25 11:56:31.554730 2024] [php:notice] [pid 37075] [client 192.168.122.1:36620] electrophysiology_uploader is missing Module class #0 /var/www/loris/php/libraries/Module.class.inc(63): Module::factory()\n#1 /var/www/loris/modules/dashboard/php/dashboard.class.inc(86): Module::getActiveModules()\n#2 /var/www/loris/php/libraries/Module.class.inc(289): LORIS\\dashboard\\Dashboard->__construct()\n#3 /var/www/loris/php/libraries/Module.class.inc(366): Module->loadPage()\n#4 /var/www/loris/src/Middleware/ResponseGenerator.php(50): Module->handle()\n#5 /var/www/loris/src/Middleware/AuthMiddleware.php(63): LORIS\\Middleware\\ResponseGenerator->process()\n#6 /var/www/loris/src/Router/ModuleRouter.php(74): LORIS\\Middleware\\AuthMiddleware->process()\n#7 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(54): LORIS\\Router\\ModuleRouter->handle()\n#8 /var/www/loris/src/Router/BaseRouter.php(133): LORIS\\Middleware\\ExceptionHandlingMiddleware->process()\n#9 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#10 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#11 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#12 {main}
[Thu Jan 25 11:56:31.740144 2024] [php:notice] [pid 37075] [client 192.168.122.1:36620] electrophysiology_uploader is missing Module class #0 /var/www/loris/php/libraries/Module.class.inc(63): Module::factory()\n#1 /var/www/loris/modules/dashboard/php/module.class.inc(140): Module::getActiveModules()\n#2 /var/www/loris/modules/dashboard/php/module.class.inc(58): LORIS\\dashboard\\Module->_getTasksWidget()\n#3 /var/www/loris/modules/dashboard/php/dashboard.class.inc(92): LORIS\\dashboard\\Module->getWidgets()\n#4 /var/www/loris/php/libraries/Module.class.inc(289): LORIS\\dashboard\\Dashboard->__construct()\n#5 /var/www/loris/php/libraries/Module.class.inc(366): Module->loadPage()\n#6 /var/www/loris/src/Middleware/ResponseGenerator.php(50): Module->handle()\n#7 /var/www/loris/src/Middleware/AuthMiddleware.php(63): LORIS\\Middleware\\ResponseGenerator->process()\n#8 /var/www/loris/src/Router/ModuleRouter.php(74): LORIS\\Middleware\\AuthMiddleware->process()\n#9 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(54): LORIS\\Router\\ModuleRouter->handle()\n#10 /var/www/loris/src/Router/BaseRouter.php(133): LORIS\\Middleware\\ExceptionHandlingMiddleware->process()\n#11 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#12 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#13 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#14 {main}
[Thu Jan 25 11:56:31.871868 2024] [php:notice] [pid 37075] [client 192.168.122.1:36620] electrophysiology_uploader is missing Module class #0 /var/www/loris/src/LorisInstance.php(79): Module::factory()\n#1 /var/www/loris/src/Middleware/UserPageDecorationMiddleware.php(59): LORIS\\LorisInstance->getActiveModules()\n#2 /var/www/loris/src/Middleware/PageDecorationMiddleware.php(57): LORIS\\Middleware\\UserPageDecorationMiddleware->process()\n#3 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(83): LORIS\\Middleware\\PageDecorationMiddleware->process()\n#4 /var/www/loris/src/Router/BaseRouter.php(133): LORIS\\Middleware\\ExceptionHandlingMiddleware->process()\n#5 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#6 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#7 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#8 {main}
[Thu Jan 25 11:56:31.880673 2024] [php:error] [pid 37075] [client 192.168.122.1:36620] PHP Fatal error:  Uncaught ConfigurationException: Config setting css does not exist in database in /var/www/loris/php/libraries/NDB_Config.class.inc:303\nStack trace:\n#0 /var/www/loris/php/libraries/NDB_Config.class.inc(415): NDB_Config->getSettingFromDB()\n#1 /var/www/loris/src/Middleware/UserPageDecorationMiddleware.php(136): NDB_Config->getSetting()\n#2 /var/www/loris/src/Middleware/PageDecorationMiddleware.php(57): LORIS\\Middleware\\UserPageDecorationMiddleware->process()\n#3 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(83): LORIS\\Middleware\\PageDecorationMiddleware->process()\n#4 /var/www/loris/src/Router/BaseRouter.php(133): LORIS\\Middleware\\ExceptionHandlingMiddleware->process()\n#5 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\\Router\\BaseRouter->handle()\n#6 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\\Middleware\\ResponseGenerator->process()\n#7 /var/www/loris/htdocs/index.php(55): LORIS\\Middleware\\ContentLength->process()\n#8 {main}\n  thrown in /var/www/loris/php/libraries/NDB_Config.class.inc on line 303

[driusan]

@CamilleBeau is this supposed to go to main or to the next bugfix release?

[CamilleBeau]

@CamilleBeau is this supposed to go to main or to the next bugfix release?

@driusan It could go to the bugfix release. What branch is that?