Loris icon indicating copy to clipboard operation
Loris copied to clipboard

[IssueTracker] Add description field to issues table

Open sanjay-thiyagarajan opened this issue 1 year ago • 8 comments

Brief summary of changes

  • Added "description" field to "issues" table
  • Created script "update_issues_with_description.php" for copying all the existing descriptions from "issues_comments" table
  • Updated raisinbread SQL file to reflect the change in field
  • Added a new field to the issue creation / modification form in the UI.

Link(s) to related issue(s)

  • Resolves #8353

sanjay-thiyagarajan avatar Aug 11 '23 06:08 sanjay-thiyagarajan

@racostas is this ready for your review?

christinerogers avatar Sep 05 '23 16:09 christinerogers

@racostas is this ready for your review?

Yes, I did a first pass with him "in person" before the end of the GSoC period. The comments were properly addressed but it's missing a second test/review. I had been a bit taken with CCNA upgrade since them. If after second review there is something to fix I will take care myself.

racostas avatar Sep 05 '23 17:09 racostas

Thanks @racostas

@SantiagoTG or @driusan or @ridz1208 could you please suggest/nominate an additional reviewer on this PR?
Just to confirm the Issue tracker comments/description will work as intended by the team.

Then it should be ready to merge to help our GSOC student wrap up his summer. thanks!

christinerogers avatar Sep 05 '23 18:09 christinerogers

Everything works well now. The only thing (but I don't think it's related to this PR) is that the "New issue" page does not load because there is a missing jsx/Form import for FileElement. This can be solved by adding this line in IssueForm.js image

I added it to test. Even though it's not caused by this PR I think it would be good to fix here

Yes, definitely something we can address in as part of this PR too. Thanks Camille.

racostas avatar Feb 07 '24 17:02 racostas

ready to be re-reviewed.

racostas avatar Feb 09 '24 16:02 racostas

@racostas I have tested the changes, and they work as expected without any issues. Looks good to me!

ay-bh avatar Jun 17 '24 17:06 ay-bh

@CamilleBeau GitHub still says you requested changes, can you re-review?

driusan avatar Jun 17 '24 18:06 driusan

@CamilleBeau GitHub still says you requested changes, can you re-review?

@driusan Done!

CamilleBeau avatar Jun 17 '24 18:06 CamilleBeau