Loris
Loris copied to clipboard
[Acknowledgements] data framework
Brief summary of changes
rewrite [Acknowledgements] data framework
Testing instructions (if applicable)
@laemtl, could you please let me know that should I code review or test this?
@kongtiaowang, @ridz1208, Could you please help me test this? there is no testing instruction on the PR or any task linked.
@miladheshmati given that its a full module change a wise thing would be to follow the module test plan
I've tested the Acknowledgements module and there was this issue:
- I am adding an acknowledgement with my name using the "Add acknowledgement" button.
- The form says it was successfully saved without showing any errors
- I am not able to see the acknowledgement that I added on the list
- I search for it using the filters but it is still not there.
- I refreshed the page and tried again and still the acknowledgement that I added is not showing anywhere
@miladheshmati I have fixed the issue. Could u test it again? Thanks
@miladheshmati Can you take a look at this one again?
@kongtiaowang @xlecours I'm getting this error on the front-end as I switch to this branch and do a make dev: