Loris icon indicating copy to clipboard operation
Loris copied to clipboard

[Acknowledgements] data framework

Open kongtiaowang opened this issue 2 years ago • 7 comments

Brief summary of changes

rewrite [Acknowledgements] data framework

Testing instructions (if applicable)

kongtiaowang avatar Feb 10 '23 18:02 kongtiaowang

@laemtl, could you please let me know that should I code review or test this?

miladheshmati avatar Feb 22 '23 00:02 miladheshmati

@kongtiaowang, @ridz1208, Could you please help me test this? there is no testing instruction on the PR or any task linked.

miladheshmati avatar Mar 27 '23 14:03 miladheshmati

@miladheshmati given that its a full module change a wise thing would be to follow the module test plan

ridz1208 avatar Mar 27 '23 14:03 ridz1208

I've tested the Acknowledgements module and there was this issue:

  • I am adding an acknowledgement with my name using the "Add acknowledgement" button.
  • The form says it was successfully saved without showing any errors
  • I am not able to see the acknowledgement that I added on the list
  • I search for it using the filters but it is still not there.
  • I refreshed the page and tried again and still the acknowledgement that I added is not showing anywhere

Screenshot 2023-03-27 at 10 37 56 AM

Screenshot 2023-03-27 at 10 38 31 AM

Screenshot 2023-03-27 at 10 39 10 AM

miladheshmati avatar Mar 27 '23 14:03 miladheshmati

@miladheshmati I have fixed the issue. Could u test it again? Thanks

kongtiaowang avatar Mar 27 '23 18:03 kongtiaowang

@miladheshmati Can you take a look at this one again?

xlecours avatar Sep 26 '23 13:09 xlecours

@kongtiaowang @xlecours I'm getting this error on the front-end as I switch to this branch and do a make dev:

Screenshot 2023-10-10 at 2 21 32 PM

miladheshmati avatar Oct 10 '23 18:10 miladheshmati