Loris [instrument_builder] ADDED: field warnings for maximum length in Instrument Builder module

[instrument_builder] ADDED: field warnings for maximum length in Instrument Builder module

Open satvik-tha-god opened this issue 2 years ago • 5 comments

…t Builder

Brief summary of changes

Added field warnings for length for _status fields:
Added field warnings for length for all the fields
Minor spelling mistake fix

Testing instructions (if applicable)

Go to /instrument_builder/#Build
Check for warnings for input length greater than 57 for the following fields by clicking Add Row
1. Data entry->Textbox->Question Name
2. Data entry->Textarea->Question Name
3. Data entry->Date->Question Name
4. Data entry->Numeric->Question Name
Check for warnings for input length greater than 64 for the rest of the Question Name and Question Text fields by clicking Add Row

Link(s) to related issue(s)

Resolves #7582

Jun 11 '22 16:06 satvik-tha-god

Great stuff, Satvik! It would be great to have an idea of how the warnings will appear to the end user - could you kindly post a screenshot in this thread, showing the error message in context? Thanks, that would be really helpful in speeding this through the review process.

Jun 13 '22 15:06 christinerogers

Great stuff, Satvik! It would be great to have an idea of how the warnings will appear to the end user - could you kindly post a screenshot in this thread, showing the error message in context? Thanks, that would be really helpful in speeding this through the review process.

@christinerogers Thanks! Here are the screenshots Screenshot from 2022-06-14 01-50-55

Jun 13 '22 20:06 satvik-tha-god

Hi @satvik-tha-god, Great work !! Please address @christinerogers comments. The unit test are falling due to code standard nonconformity. You will be able to identify the error entering in the failed test and searching for the error keyword in the output. For this case are simple ones. I attach a screenshot for reference.