Loris icon indicating copy to clipboard operation
Loris copied to clipboard

[help_editor] fix preview button

Open maltheism opened this issue 3 years ago • 1 comments

Brief summary of changes

This PR updates the position of the preview dialogue when clicking on the preview button of the help editor. It also correctly sources the sweetalert library from htdocs/vendor because help_editor_helper.js is vanilla javascript and isn't compiled with webpack (needed for using import).

Testing instructions (if applicable)

  1. Checkout PR
  2. Visit the help_editor module
  3. click on bmi in the table (example rasinbread)
  4. Click the preview button.

Link(s) to related issue(s)

  • Resolves #6968

maltheism avatar Dec 07 '21 19:12 maltheism

Here is the screenshot of the result. The preview button now works @ridz1208

Screen Shot 2021-12-16 at 1 42 45 PM

shonibare avatar Dec 16 '21 18:12 shonibare

Works too preview_popup_ok

regisoc avatar Dec 06 '22 14:12 regisoc

@shonibare @regisoc if this is approved, can you approve the PR? Thanks!

cmadjar avatar Dec 06 '22 15:12 cmadjar

@driusan PR was approved by Regis. In your code for final review.

cmadjar avatar Dec 06 '22 15:12 cmadjar