Loris icon indicating copy to clipboard operation
Loris copied to clipboard

[Configuration] www.host Config value displayed based on xml

Open xlecours opened this issue 4 years ago • 7 comments

Describe the bug The value displayed in the configuration module for the host under WWW comes from the xml file () instead of the Config table. Screen Shot 2020-11-20 at 9 50 55 AM

This might be somewhat related to https://github.com/aces/Loris/issues/5613

xlecours avatar Nov 20 '20 15:11 xlecours

Anything can come from the XML instead of the config table. If a setting exists in the config.xml that takes priority and should be greyed out/uneditable in the frontend, otherwise it comes from the config. What's the problem?

driusan avatar Nov 20 '20 15:11 driusan

@driusan The problem is that we have 2 host configs. The one under www in the config table and the one under database in the config.xml-->lorisdb.xml

What we see in the Configuration module is the value of the database.host instead of www.host

xlecours avatar Nov 20 '20 18:11 xlecours

Oh, I see. Is www.host still used anywhere? I'm not seeing anything in the code but both git grep www and git grep host are pretty noisy searches so I might be missing something.

driusan avatar Nov 20 '20 19:11 driusan

@driusan There are so many ways to get that values. I can't tell for sure but I know that this line is specifically asking for it. And this one too.

xlecours avatar Nov 25 '20 15:11 xlecours

The raisinbread one looks like it's just keeping the session so it can restore it when it does a dump.. the email one is trickier, in the email context you can't derive the host from the incoming URL..

driusan avatar Nov 25 '20 15:11 driusan

@xlecours @driusan do you know if this is still an issue ?

ridz1208 avatar Mar 11 '22 21:03 ridz1208

I think so. The value displayed on test is localhost instead of the hostname. I think localhost is the database hostname.

xlecours avatar Mar 14 '22 13:03 xlecours