Loris icon indicating copy to clipboard operation
Loris copied to clipboard

[document_repository] New features

Open pierre-p-s opened this issue 4 years ago • 9 comments

Brief summary of changes

  • Changed view permission to only allow viewing of documents (Only browse tab accessible)
  • Added an upload and edit permission (allows users to upload a document or to edit any documents in doc repo)
  • Created a new permission: hidden files. Allows users that have the permission to hide files from users that do not have it.
  • New tab: "Edit Categories". Allows to change the name of a category as well as its parent category.
  • Created a new permission: categories. The edit categories and add categories do not appear unless you have this permission.

Testing instructions (if applicable)

  1. Check with another account (not admin) that the permissions listed above behave as expected (the tabs appear as expected).
  2. Upload a document when you have the hidden file permission and set the file to restricted. Check with an account that does not have the hidden file permission that this file does not appear in the doc tree. Check that it appears when you have the permission. Also check that when uploading a file or editing one, the restrict access option is not available if you do not have the hidden file permission
  3. With the categories permission, create a new permission. Check that the category has the right name under the right parent category. Using the edit categories tab, edit the name of the category and change the parent category. Check that the category was moved accordingly and has the right name.
  4. When editing a file, you should be able to change the category of the file.

Link(s) to related issue(s)

  • Resolves #7099

@LeighMac please let me know if these features were the ones you were looking for.

pierre-p-s avatar Oct 30 '20 05:10 pierre-p-s

@kongtiaowang I dont really know what is happening with the test suite do you think you could help me please?

pierre-p-s avatar Apr 29 '21 18:04 pierre-p-s

@kongtiaowang could you help @pierre-p-s with the test suite?

cmadjar avatar Jun 08 '21 13:06 cmadjar

@jstirling91 could you review this? Thanks!

cmadjar avatar Jul 13 '21 14:07 cmadjar

@jstirling91 could you re-review please?

cmadjar avatar Aug 10 '21 14:08 cmadjar

@CamilleBeau Can you verify is this is still needed?

laemtl avatar Dec 20 '22 14:12 laemtl

@CamilleBeau Can you verify is this is still needed?

@laemtl Yes, most of these changes have not been made yet.

CamilleBeau avatar Dec 21 '22 17:12 CamilleBeau

I'm not able to find any specific errors in the test suite - would anyone be able to help with this?

CamilleBeau avatar Dec 07 '23 15:12 CamilleBeau

@CamilleBeau https://github.com/aces/Loris/blob/main/raisinbread/RB_files/RB_permissions.sql needs to update.

kongtiaowang avatar Jan 09 '24 17:01 kongtiaowang

@CamilleBeau Please update the code in document_repository/test/document_repositoryTest.php, in line 116,119, 133 and 140. change "category" to "addCategory" in url and cssSelector section.

kongtiaowang avatar Jan 15 '24 17:01 kongtiaowang

@CamilleBeau or someone else on CCNA to rebase/fix conflicts

ridz1208 avatar Jul 02 '24 13:07 ridz1208