Loris icon indicating copy to clipboard operation
Loris copied to clipboard

[Genomic Browser] Issues with the Profiles Tab Datatable.

Open HenriRabalais opened this issue 4 years ago • 6 comments

Describe the bug A. Since there are no files uploaded in raisinbread for the Genomic Browser, clicking on a file value is not possible. Therefore, the "viewGenomicFile" file view cannot be tested as outlined by the test plan.

B. ~~When there is a SNP for a candidate, the "Y" can be clicked to go to the SNP for that candidate, but the link is not obvious since it is presented as regular text. (PR SENT #6523)~~

C. ~~There are no profiles with CNV or CPG data, so clicking on the link for those can't be tested. (PR SENT #6900)~~

Test Plan Reference: https://github.com/aces/Loris/blob/master/modules/genomic_browser/test/TestPlan.md#special-formated-columns

To Reproduce Steps to reproduce the behavior (attach screenshots if applicable):

  1. Go to the Profiles Tab of the Genomic Browser
  2. Look at the columns for File, SNP, CNV and CPG

image

HenriRabalais avatar Apr 06 '20 18:04 HenriRabalais

@xlecours will you be able to address this ?

ridz1208 avatar Apr 15 '20 15:04 ridz1208

My $0.02:

  • a+c are RaisinBread/test-data issues (like #6298 which duplicates #5180, still open from 22 release)
  • b is a design choice, not a bug - could be improved upon but not sure it's release-critical.

christinerogers avatar Apr 15 '20 22:04 christinerogers

@ridz1208 It would be low on my priorities list.

xlecours avatar Apr 16 '20 17:04 xlecours

I think this issue can be closed after #6523 is resolved/merged to address point B. A and C are not testable in this round at least.

christinerogers avatar May 12 '20 19:05 christinerogers

splitting off issue C for @AlexandraLivadas : issue 6302

christinerogers avatar Aug 05 '20 15:08 christinerogers

The referenced PR says it only partially resolves this.

driusan avatar Aug 19 '20 19:08 driusan